Security Fix for Prototype Pollution - huntr.dev#6
Open
huntr-helper wants to merge 2 commits intogammasoft:masterfrom
Open
Security Fix for Prototype Pollution - huntr.dev#6huntr-helper wants to merge 2 commits intogammasoft:masterfrom
huntr-helper wants to merge 2 commits intogammasoft:masterfrom
Conversation
Fixed Prototype Pollution on deepMerge and deepSet
|
I wanted to ask if this PR will be merged to fixed prototype pollution and the package is to be bumped? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://huntr.dev/users/Asjidkalam has fixed the Prototype Pollution vulnerability 🔨. Asjidkalam has been awarded $25 for fixing the vulnerability through the huntr bug bounty program 💵. Think you could fix a vulnerability like this?
Get involved at https://huntr.dev/
Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | 418sec#1
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/npm/gammautils/1/README.md
User Comments:
📊 Metadata *
Prototype Pollution bug
Bounty URL: https://www.huntr.dev/bounties/1-npm-gammautils
⚙️ Description *
gammautils is a Lots of utilities for Node.js, this package is vulnerable to Prototype Pollution via the. deepSet and deepMerge functions.
Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as
_proto_,constructorandprototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.💻 Technical Description *
The bug is fixed by validating the input
keyto check for prototypes. It is implemented by a simple validation to check for prototype keywords(__proto__, constructor and prototype), where if it exists, the function returns the object without modifying it, thus fixing the Prototype Pollution Vulnerability.🐛 Proof of Concept (PoC) *
Clone the project, install the required dependencies and on running the below snippet of code, it triggers prototype pollution and logs
123.🔥 Proof of Fix (PoF) *
After the fix is applied, it returns an error since the polluted referred in the PoC is no more accessible(which is intended). Hence fixing the issue.
👍 User Acceptance Testing (UAT)
Just prevented some keywords as
key,destinationand no breaking changes are introduced. :)